Fix world border filter NPE #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablete1234 <[email protected]>
Electroid
approved these changes
Sep 2, 2022
Samuel-Roach
pushed a commit
to Samuel-Roach/PGM
that referenced
this pull request
Sep 3, 2022
Signed-off-by: Pablete1234 <[email protected]> Signed-off-by: Samuel Roach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
World border creates a monostable filter but does not register it in the filter context, that means that on match load the reactor for it is not created, which causes it to NPE and not work.
The fix was supposed to be simple: add it to the context. However along the way i discovered significant issues with context not actually putting the added stuff in the correct lists, and getAll not properly returning it, making it still not work. After all these changes tho, it finally does work.
Fixes #1051